[PM-15360] Consider Credential Exchange export policies. #1263
+43
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedemkr
requested review from
matt-livefront,
phil-livefront,
brant-livefront and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1263 +/- ##
=======================================
Coverage 89.46% 89.46%
=======================================
Files 732 732
Lines 46148 46159 +11
=======================================
+ Hits 41286 41297 +11
Misses 4862 4862 ☔ View full report in Codecov by Sentry. |
|
Great job, no security vulnerabilities found in this Pull Request |
Comment on lines
159
to
170
| subject.state.showMainButton = false | ||
| let task = Task { | ||
| await subject.perform(.cancel) | ||
| } | ||
| defer { task.cancel() } | ||
|
|
||
| try await waitForAsync { [weak self] in | ||
| guard let self else { return true } | ||
| return !coordinator.routes.isEmpty | ||
| } | ||
|
|
||
| XCTAssertEqual(.dismiss, coordinator.routes.last) |
There was a problem hiding this comment.
🎨 Could this test be simplified to avoid the extra task and waitFor? It seems like everything in this flow uses async/await so the waitFor might not be necessary?
matt-livefront
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-15360
📔 Objective
Fail CXP export if disable personal vault export policy is enabled.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes